Albert Barnes Commentary Ecclesiastes 12:2

"before the sun, and the light, and the moon, and the stars, are darkened, and the clouds return after the rain;" — Ecclesiastes 12:2 (ASV)

While ... not - Or, Before. The darkening of the lights of heaven denotes a time of affliction and sadness. Compare Ezekiel 32:7-8; Job 3:9; Isaiah 5:30. Contrast this representation of old age with 2 Samuel 23:4–5.