A.T. Robertson Commentary 1 John 4:10

"Herein is love, not that we loved God, but that he loved us, and sent his Son [to be] the propitiation for our sins." — 1 John 4:10 (ASV)

Not that (ουχ οτ)

--but that (αλλ' οτ). Sharp contrast as in Joh 7:22; 2 Corinthians 7:9; Php 4:17.

We loved (ηγαπησαμεν). First aorist active indicative, but B reads ηγαπηκαμεν (perfect active, we have loved).

He (αυτος). Emphatic nominative (God).

To be the propitiation (ιλασμον). Merely predicate accusative in apposition with υιον (Son). For the word see 2:2; Romans 3:25 for ιλαστηριον, and for περ see also 2:2.