Charles Ellicott Commentary 2 Samuel 23:5

"Verily my house is not so with God; Yet he hath made with me an everlasting covenant, Ordered in all things, and sure: For it is all my salvation, and all [my] desire, Although he maketh it not to grow." — 2 Samuel 23:5 (ASV)

Although my house. —This verse is extremely difficult and admits of two interpretations. The interpretation given in the English version is also found in the Septuagint, the Vulgate, and the Syriac. If adopted, it means that David recognizes how far he and his house have failed to realize the ideal description set forth; yet since God’s promise is sure, this must be realized in his posterity.

Most modern commentators, however, prefer to take the clauses interrogatively: “Is not my house thus with God? for He hath made with me an everlasting covenant, ordered in all, and sure. For all my salvation and all my desire, shall He not cause it to spring forth?” The Hebrew admits either rendering, but the interpretation from the ancient versions gives a higher idea of David’s spiritual discernment.

Ordered in all. —As a carefully drawn legal document, providing for all contingencies and leaving no room for misconstruction.