John Gill Commentary 1 Samuel 25:30

"And it shall come to pass, when Jehovah shall have done to my lord according to all the good that he hath spoken concerning thee, and shall have appointed thee prince over Israel," — 1 Samuel 25:30 (ASV)

And it shall come to pass, when the Lord shall have done to my
lord according to all the good that he has spoken concerning thee ,
&c.] Performed his promise, especially with respect to his kingdom, as follows:

and shall have appointed thee ruler over Israel ;
that is, actually raised him to be, and settled him as king upon the throne of Israel; for he was both appointed and anointed already; and this Abigail knew, and was now well known in Israel, and the common talk of the people.