John Gill Commentary 2 Chronicles 24:10

"And all the princes and all the people rejoiced, and brought in, and cast into the chest, until they had made an end." — 2 Chronicles 24:10 (ASV)

And all the princes and all the people rejoiced
When they heard the proclamation, and understood for what use the money was to be given, and in what manner; all was agreeable and pleasing to them:

and brought in, and cast into the chest ;
through the hole that was in the lid of it, (2 Kings 12:9) ,

until they had made an end :
everyone had given as much as he could, or thought fit to give.