John Gill Commentary Jeremiah 38:28

"So Jeremiah abode in the court of the guard until the day that Jerusalem was taken." — Jeremiah 38:28 (ASV)

So Jeremiah abode in the court of the prison Where he was ordered to be by the king, before he was cast into the dungeon, and where he was replaced by Ebedmelech; and which was now confirmed by the king, and here he continued: until the day that Jerusalem was taken ; but how long it was from his conversation with the king, to the taking of the city, is not certain: and he was [there] when Jerusalem was taken ; as appears from (Jeremiah 39:14) . Kimchi connects this with the beginning of the next chapter; and so the Targum, rendering it, ``and it came to pass when Jerusalem was taken;'' namely, what is related in the following chapter.